[pacman-dev] [PATCH] Refactor the trans init and release code.

Xavier shiningxc at gmail.com
Sat Apr 26 11:39:14 EDT 2008


Dan McGee wrote:
>>  +int trans_init(pmtranstype_t type, pmtransflag_t flags)
>>  +{
>>  +       if(alpm_trans_init(type, flags, cb_trans_evt,
>>  +                               cb_trans_conv, cb_trans_progress) == -1) {
>>  +               /* TODO: error messages should be in the front end, not the back */
> This comment is a bit stale, we can probably remove it. Printing error
> messages in the backend is wrong, but having a message callback is
> fine. I think this one is my fault a while back.
> 

yes right, I wasn't sure about that.
I removed the comment and pushed the patch to dreamhost.




More information about the pacman-dev mailing list