[pacman-dev] [PATCH] Add documentation for transaction events

Xavier shiningxc at gmail.com
Sun Apr 27 05:03:28 EDT 2008


Sebastian Nowicki wrote:
> +
> +	/** Package waas extracted
> +	 *
> +	 * No parameters are passed
> +	 */
>  	PM_TRANS_EVT_EXTRACT_DONE,

s/waas/was

> +
> +	/** Target deltas's integrity will be checked
> +	 *
> +	 * No parameters are passed
> +	 */
>  	PM_TRANS_EVT_DELTA_INTEGRITY_START,

Shouldn't it be deltas' or something? Not even sure :)


Except these two typos, it looks alright. I just had the same first 
impression as Dan, it looks a bit intrusive. Though you already removed 
one line from the original patch, but too bad we can't remove more.

I was thinking, do we really need to specify "No parameters are passed" 
every time? Maybe having no description could implicitly means that no 
parameters are passed.




More information about the pacman-dev mailing list