[pacman-dev] [PATCH] Rework extract_single_file() temp file creation
dan at archlinux.org
Mon Apr 28 23:39:26 EDT 2008
On Mon, Apr 28, 2008 at 10:34 PM, Dan McGee <dan at archlinux.org> wrote:
> We were a bit juryrigged using one call to mkstemp() before rather than
> extracting the new files side-by-side and doing our comparisons there. We
> were also facing some permissions issues. Instead, make our life easier by
> extracting all temp files to a '.paccheck' extension, doing our md5
> comparisons, and then taking the correct actions.
> Still to be done here- a cleanup of the use of PATH_MAX which should not be
> necessary if we use dynamic allocation on the heap.
> Signed-off-by: Dan McGee <dan at archlinux.org>
I posted these patches here because I would love to get some feedback
on them from you guys, and they need some real-life testing. The
biggest catch with this patch is ensuring we don't leave any paccheck
files behind, as we can no longer always unlink the original file
since we use rename instead of copy.
All of these can be found on my public 'working' branch if you are
tracking my GIT repository. I'll hold off a few days before pushing
these to master.
More information about the pacman-dev