[pacman-dev] [PATCH] Change download functions to handle funny urls

Xavier shiningxc at gmail.com
Fri Aug 1 16:01:10 EDT 2008

On Fri, Aug 1, 2008 at 12:59 AM, Henning Garus
<henning.garus at googlemail.com> wrote:
> Stop urls containing & or ? from breaking get_downloadclient()
> and get_downloadcmd().
> Fixes FS#11076
> Signed-off-by: Henning Garus <henning.garus at gmail.com>

Well we already discussed in private mails while the ML was down, so
here is an extract for others :

(my comment)
> Now more on the technical side, your patch looks good to me, and it
> worked fine in my test, but I also found a decent alternative thanks
> to your help. The differences are usage of bash substitution instead
> of awk, and only enabling nullopt where it is needed, instead of
> disabling expansion.
> http://shining.toofishes.net/gitweb/gitweb.cgi?p=pacman.git;a=commitdiff;h=60ebe3f51efe72fb9ea15e7d17170c062d731f1c
> To be honest, I have no idea which way is best, so I will let you
> decide :)

(Henning's answer)
For me using bash expansion looks saner than my awk hackery.
Changing get_download_cmd() to download_file() looks good as well, so I
would stick with your patch.

More information about the pacman-dev mailing list