[pacman-dev] [PATCH] dload.c : drop the specific handling of file: url.

[Xavier]

On Sun, Aug 3, 2008 at 8:55 PM, Xavier Chantry <shiningxc at gmail.com> wrote:
> Before commit fc48dc31, file:/// urls forced the use of the internal
> downloader (libdownload), because the default XferCommand, wget, does not
> handle them.
> We tried to move away from forcing usage of libdownload, so this commit
> implemented the handling of file:/// urls manually. However, this
> implementation is way too basic. It does not handle the progress bar, thus
> nothing at all appears in pacman's output when a file: repo is synchronized,
> or when a file is downloaded from a sync repo. Also, it is not able to
> detect when the repo is already up-to-date. When libdownload was used, both
> were handled.
> So it seems better to just drop this implementation for now. All users who
> use libdownload will get the much better file:// handling back. For the
> users of XferCommand, it will be more problematic, but they have several
> options:
> 1) switch to a downloader handling file:// (wget doesn't, but curl does for
> example)
> 2) drop the file:// repo, and set up light http or ftp servers instead.
> Consider that going that way would make this repo available for the whole
> local network, which can be useful
> 3) switch back to libdownload, which works perfectly for many users
>

A stupid issue caused by that patch is that sync200 now fails on
systems without libdownload support.
Attaching a patch for sync200 to work around it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-sync200-pactest-to-pass-without-libdownload.patch
Type: application/mbox
Size: 1929 bytes
Desc: not available
URL: <http://archlinux.org/pipermail/pacman-dev/attachments/20080806/55d54913/attachment.bin>