[pacman-dev] [PATCH] Fix segfault on x86_64 when using UseSyslog

Xavier shiningxc at gmail.com
Sun Aug 10 13:35:26 EDT 2008


On Sun, Aug 10, 2008 at 6:53 PM, Dan McGee <dpmcgee at gmail.com> wrote:
>
> Note the difference here. Our function doesn't have the ... in the arg
> list- we are already passing in a va_list parameter, so the va_start
> was done elsewhere which gave us the va_list to work on.
>

Oh I see, and alpm_logaction does just that, for this _alpm_logaction function.
So that patch looks perfect.

Hm, just the commit log that I find a bit confusing :
va_list usage is not allowed

Shouldnt it be like in the code comment :
va_list can't be used more than once



More information about the pacman-dev mailing list