[pacman-dev] [PATCH] makepkg : allow to specify a download filename

[Allan McRae]

Xavier Chantry wrote:
> A source entry can now have the following form, to specify a different
> filename :
> "filename::http://path/to/file"
>
> Of course, the old syntax is still supported :
> "http://path/to/file"
>
> And as before, in the second case, the filename used is simply "file".
>
> This fixes FS#11292, because handling multiple source files with the same
> name is now possible (just choose a different filename).
>
> But it will also allow to deal much more nicely with funny url like this by
> using a sane filename (and unfortunately, there are quite a few) :
> http://www.vim.org/scripts/download_script.php?src_id=6992
>
> Signed-off-by: Xavier Chantry <shiningxc at gmail.com>
> ---
>  doc/PKGBUILD.5.txt    |    4 +++
>  scripts/makepkg.sh.in |   65 ++++++++++++++++++++++++++++++++++---------------
>  2 files changed, 49 insertions(+), 20 deletions(-)
>
>   

Looks good. A missing %o in DLAGENTS did need to be supported as the 
makepkg.conf man pages says that it is optional. As a side note, the 
description of %u being replaced by the url if present or the url being 
placed at the end needs tidied up in the man page as it currently sounds 
like putting the url at the end will alway happen.

Allan