[pacman-dev] [PATCH] HoldPkg rework

[Xavier]

On Sun, Aug 24, 2008 at 11:34 PM, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> >From f6af53eed61c3088d756cba021b03266a0702ce8 Mon Sep 17 00:00:00 2001
> From: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> Date: Sun, 24 Aug 2008 23:24:53 +0200
> Subject: [PATCH] HoldPkg rework
>
> The HoldPkg feature is even more important when the packages to be held are
> pulled automatically by pacman, in a -Rc and -Rs operation. Before, it only
> applied when the packages were explicitly requested by the user to be
> removed. This patch extends holdpkg to -Rc and -Rs by doing the HoldPkg
> check just before trans_commit.
>
> Additionally, the whole HoldPkg stuff was moved to the front-end.
>
> I changed the default behavior to "don't remove", so I modified remove030.py
> pactest as well.
>
> See also: FS#9173.
>
> Original-work-by: Xavier Chantry <shiningxc at gmail.com>
> Signed-off-by: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> ---
>  lib/libalpm/alpm.h         |   10 +---------
>  lib/libalpm/error.c        |    3 ---
>  lib/libalpm/handle.c       |   32 --------------------------------
>  lib/libalpm/handle.h       |    1 -
>  lib/libalpm/remove.c       |   10 ----------
>  pactest/tests/remove030.py |    6 ++----
>  src/pacman/callback.c      |    4 ----
>  src/pacman/conf.c          |    2 ++
>  src/pacman/conf.h          |    1 +
>  src/pacman/pacman.c        |    7 ++++++-
>  src/pacman/remove.c        |   15 +++++++++++++++
>  11 files changed, 27 insertions(+), 64 deletions(-)
>


I like it, this patch looks nice and removes more junk than I
expected. Great job!