[pacman-dev] PKGBUILD.proto

[Eric Bélanger]

On Sat, 6 Dec 2008, Allan McRae wrote:

> Jud wrote:
>> Hi,
>> 
>> Dan suggested I send this to the pacman-dev list.
>> 
>> After completing some research and asking alot of questions I present
>> some minor changes to PKGBUILD.proto supplied as a .diff to be merged
>> after your approval. I believe it helps the intended audience create a
>> better PKGBUILD in less time according to the latest Arch Packaging
>> Standards.
>> 
>> Cheers
>> Jud
>> 
>> 
>> Inline:
>> --- PKGBUILD.proto	2008-12-05 23:32:33.000005000 +1000
>> +++ PKGBUILD.proto.new	2008-12-05 23:37:45.374547000 +1000
>> @@ -3,13 +3,15 @@
>>  # NOTE: Please fill out the license field for your package! If it is
>> unknown, # then please put 'unknown'.
>>  -# Contributor: Your Name <youremail at domain.com>
>> +
>> +# Contributor: Your Name <youremail at domain.com> # Use dots only to
>> reduce spam +
>> 
>
> I'm sure people can figure that out for themselves....
>
>>  pkgname=NAME
>> -pkgver=VERSION
>> +pkgver=VERSION # Note: if pkgver is '0.99-10' then use an underscore,
>> i.e. '0.99_10' pkgrel=1
>>  pkgdesc=""
>> -arch=()
>> -url=""
>> +url="http://ADDRESS/"
>> +arch=('i686' 'x86_64')

By convention, the arch field goes right after the pkgdesc


>>  license=('GPL')
>>  groups=()
>>  depends=()
>> @@ -20,17 +22,13 @@
>>  replaces=()
>>  backup=()
>>  options=()
>> -install=
>> -source=($pkgname-$pkgver.tar.gz)
>> -noextract=()

Why did you removed the noextract field? Was it done by mistake?

>> -md5sums=() #generate with 'makepkg -g'
>> +install=(${pkgname}.install)
>> 
>
> I really dislike the brackets there.  install holds a value not an array much 
> like pkgname, pkgrel.
>
>> +source=(http://ADDRESS/TO/FILE/${pkgname}-${pkgver}.tar.gz)
>> +md5sums=() # Generate with 'makepkg -g'
>>   build() {
>> -  cd "$srcdir/$pkgname-$pkgver"
>> -
>> -  ./configure --prefix=/usr
>> +  cd ${srcdir}${pkgname}-${pkgver}

you forgot a /


>> +  ./configure --prefix=usr
>>    make || return 1
>> -  make DESTDIR="$pkgdir/" install
>> +  make DESTDIR=${pkgdir} install || return 1
>>  }
>> -
>> -# vim:set ts=2 sw=2 et:
>>   ------------------------------------------------------------------------


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.