[pacman-dev] small libdownload patch

[Aaron Griffin]

On Sat, Dec 27, 2008 at 5:15 AM, Xavier <shiningxc at gmail.com> wrote:
> On Sat, Dec 27, 2008 at 8:58 AM, Roman Kyrylych
> <roman.kyrylych at gmail.com> wrote:
>>
>> ...and that bug is fixed there long before in FreeBSD's libfetch.
>> Thanks for info, Aaron! I wasn't aware that NetBSD has their own libfetch.
>> Looks like NetBSD's libfetch was heavily reworked in some places,
>> including some new features added.
>
> Indeed NetBSD's libfetch looked pretty good last time I checked.
>
>> The only thing it's missing from FreeBSD's lbfetch is
>> support for HTTP 1.1 If-Modified-Since behavior
>> (which was only added less than 2 weeks ago).
>>
>
> I believe they merge the changes from times to times, so it should be
> included eventually, we just need to be patient :)
>
>> There's one Linux-compatability fix after 2.20:
>> http://cvsweb.se.netbsd.org/cgi-bin/bsdweb.cgi/pkgsrc/net/libfetch/files/ftp.c.diff?r1=1.24;r2=1.25
>> Not sure if it's important enough for us though.
>>
>
> That is very cool, it is actually the only patch we needed :
> http://code.phraktured.net/?p=libfetch.git;a=shortlog;h=refs/heads/linux
> The only thing left is to provide a linux Makefile, which Aaron already did.

Actually, that patch isn't even needed if we build with
CFLAGS="-D_GNU_SOURCE". It still should be merged upstream though,
I'll poke the maintainer at some point.