[pacman-dev] [PATCH] Clarify remove error message.

[Dan McGee]

On Feb 2, 2008 4:51 PM, Chantry Xavier <shiningxc at gmail.com> wrote:
> Signed-off-by: Chantry Xavier <shiningxc at gmail.com>
> ---
>  src/pacman/remove.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/pacman/remove.c b/src/pacman/remove.c
> index 56837fa..ee4e84a 100644
> --- a/src/pacman/remove.c
> +++ b/src/pacman/remove.c
> @@ -108,8 +108,7 @@ int pacman_remove(alpm_list_t *targets)
>                 char *targ = alpm_list_getdata(i);
>                 if(alpm_trans_addtarget(targ) == -1) {
>                         printf("failed.\n");
> -                       fprintf(stderr, _("error: failed to add target '%s' (%s)\n"), targ,
> -                               alpm_strerrorlast());
> +                       fprintf(stderr, _("error: could not find '%s' to remove\n"), targ);
>                         remove_cleanup();
>                         FREELIST(finaltargs);
>                         return(1);

I've actually been putting this one off for a reason- currently this
error message, although not apparant to the normal user, appears all
over when we can't add a target (package) to a package list (in this
case a removal list). I'm hesitant to change the message in this one
place because of the use of the word 'add'. Can we think of something
that can be used everywhere (sync, add, remove)?

"error: failed to find target '%s'" perhaps?

-Dan