[pacman-dev] [PATCH] Clarify the "failed to add target" errors.

[Xavier]

Nagy Gabor wrote:
>> So should I change in my patch from :
>> fprintf(stderr, _("error: '%s': %s\n"),
>> 	targ, alpm_strerrorlast());
>> to
>> fprintf(stderr, _("error: failed to find target '%s' (%s)\n"),
>> 	targ, alpm_strerrorlast());
>>
>> for sync.c , remove.c and add.c ?
>>
>
> my vote: yes
> [Note: you should patch line 632 in sync.c; and may rephrase the other error
> messages around this step1 part.]
>

Actually, that message would not be acceptable in sync.c, line 570.

569 if(pm_errno != PM_ERR_PKG_NOT_FOUND) {
570   fprintf(stderr, _("error: failed to find target '%s'\n"),
571        (char *)i->data, alpm_strerrorlast());

This error is not displayed when the package is not found, but when 
something else happens.

So I am not going to change my previous patch. I will let Dan choose 
whether he accepts it or not (he already pulled it in his maint branch : 
http://code.toofishes.net/gitweb.cgi?p=pacman.git;a=shortlog;h=maint).

In any cases (whether my patch is applied or not), you are free to 
propose another patch, since you are apparently not satisfied.