[pacman-dev] [PATCH] makepkg: Support for resuming source downloads

[Roman Kyrylych]

Hi!

The inability of makepkg to resume broken source downloads annoyed me
pretty much, so here's a patch attached. ;-)

Before applying the patch:

$ makepkg -o
==> Making package: audacious-itouch-control 0.1.1-2  (неділя, 10
лютого 2008 17:23:53 +0200)
==> Retrieving Sources...
  -> Downloading itouch-control-0.1.1.tar.gz...
[ . . . skipped . . . ]
13% [====>                                   ] 44 560     24,7K/s
==> ERROR: Aborted by user! Exiting...

[roman at home audacious-itouch-control]$ makepkg -o
==> Making package: audacious-itouch-control 0.1.1-2  (неділя, 10
лютого 2008 17:24:04 +0200)
==> Retrieving Sources...
  -> Using cached copy of itouch-control-0.1.1.tar.gz
==> Validating source files with md5sums...
    itouch-control-0.1.1.tar.gz ... FAILED
==> ERROR: One or more files did not pass the validity check!

This is because makepkg doesn't know if file is complete, or not.
But pacman is able to resume downloads.
This inspired me to do a very similar implementation in makepkg.

After applying the patch:

[roman at home audacious-itouch-control]$ makepkg -o
==> Making package: audacious-itouch-control 0.1.1-2  (неділя, 10
лютого 2008 17:28:22 +0200)
==> Retrieving Sources...
  -> Downloading itouch-control-0.1.1.tar.gz...
[ . . . skipped . . . ]
12% [====>                                   ] 41 672     24,2K/s
==> ERROR: Aborted by user! Exiting...

[roman at home audacious-itouch-control]$ makepkg -o
==> Making package: audacious-itouch-control 0.1.1-2  (неділя, 10
лютого 2008 19:04:24 +0200)
==> Retrieving Sources...
  -> Downloading itouch-control-0.1.1.tar.gz...
[ . . . skipped . . . ]
80% [+++++++========================>        ] 259 593    --.-K/s   in 16m 40s

2008-02-10 19:21:07 (197 B/s) - Read error at byte 259593/323774
(Connection timed out). Продовження спроб.

--2008-02-10 19:21:08--  (спроба: 2)
[ . . . skipped . . . ]
100%[++++++++++++++++++++++++++++++++=======>] 323 774    18,1K/s   in 3,5s

2008-02-10 19:21:12 (18,1 KB/s) - `itouch-control-0.1.1.tar.gz.part'
saved [323774/323774]

==> Validating source files with md5sums...
    itouch-control-0.1.1.tar.gz ... Passed
==> Extracting Sources...
  -> bsdtar -x -f itouch-control-0.1.1.tar.gz
==> Sources are ready.


The patch also includes changes to man makepkg.conf, and makepkg.conf
itself, because of introduced %o and %u pseudo-variables (same as in
XferCommand).

-- 
Roman Kyrylych (Роман Кирилич)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-makepkg-Support-for-resuming-source-downloads.patch
Type: text/x-patch
Size: 3205 bytes
Desc: not available
URL: <http://archlinux.org/pipermail/pacman-dev/attachments/20080210/2fb3b17d/attachment.bin>