[pacman-dev] [PATCH] get_filename : use the FILENAME field from the db.

[Nathan Jones]

On Thu, Feb 14, 2008 at 07:53:02PM +0100, Xavier wrote:
> Xavier wrote:
> > 
> > Oh crap, but that means we have a bigger issue here. The delta code 
> > needs the filename of the locally installed package, and we don't store 
> > that filename in the local db. So it actually relies on the broken way 
> > to construct the filename.
> > Well, it looks like it works in a default database generated by repo-add 
> > (where filename = name-version-arch.pkgext), so that probably explains 
> > why it worked fine with pacman-git and delta-test repo.
> > However, all official databases (core,extra,testing,unstable,community) 
> > breaks this assumption for most packages.
> 
> As Dan suggested off list, the delta machine should probably work on 
> filenames rather than just versions (in the delta metainfo file from the 
> sync databases for a start).
> That way we don't need to store filenames in the local db (which 
> wouldn't be used otherwise anyway).

I suppose so. Doing so would also allow us to check the md5sum of the
previous package to make sure the delta would apply correctly before
downloading.