[pacman-dev] [PATCH] Do not warn about up to date package when downloading only

[Dan McGee]

On Feb 17, 2008 10:18 PM, Allan McRae <mcrae_allan at hotmail.com> wrote:
> Hi,
>
> Just giving this small patch a bump.  Originally submitted on 2008-02-03.
>
> Cheers,
> Allan
>
>
> >From 639b29c35ffd82d5bb3bc4e17bac4a5f6504ca8a Mon Sep 17 00:00:00 2001
> From: Allan McRae <mcrae_allan at hotmail.com>
> Date: Sun, 3 Feb 2008 11:59:36 +1000
> Subject: [PATCH] Do not warn about up to date package when downloading only
>
> Stops the "<pkg> is up to date -- reinstalling" message when using the
> download only flag.
> Ref: http://archlinux.org/pipermail/pacman-dev/2008-January/010952.html
>
> Signed-off-by: Allan McRae <mcrae_allan at hotmail.com>
> ---
>  lib/libalpm/sync.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c
> index 6f2febc..1fc5c19 100644
> --- a/lib/libalpm/sync.c
> +++ b/lib/libalpm/sync.c
> @@ -313,8 +313,10 @@ int _alpm_sync_addtarget(pmtrans_t *trans, pmdb_t *db_local, alpm_list_t *dbs_sy
>                                                 alpm_pkg_get_name(local), alpm_pkg_get_version(local));
>                                 return(0);
>                         } else {
> -                               _alpm_log(PM_LOG_WARNING, _("%s-%s is up to date -- reinstalling\n"),
> -                                               alpm_pkg_get_name(local), alpm_pkg_get_version(local));
> +                               if(!(trans->flags & PM_TRANS_FLAG_DOWNLOADONLY)) {
> +                                       _alpm_log(PM_LOG_WARNING, _("%s-%s is up to date -- reinstalling\n"),
> +                                                       alpm_pkg_get_name(local), alpm_pkg_get_version(local));
> +                               }
>                         }
>                 }
>         }

Looks like this got lost, sorry. Thanks for giving it a poke.

I have no objections, does anyone else? I can slip this into 3.1.2
which I want to release tomorrow.

-Dan