[pacman-dev] [PATCH] Use dynamic string allocation in package structures

[Aaron Griffin]

On Jan 11, 2008 12:58 AM, Dan McGee <dan at archlinux.org> wrote:
> This also affects all structures with static strings, such as depmiss,
> conflict, etc. This should help a lot with memory usage, and hopefully make
> things a bit more "idiot proof".
>
> Currently our pactest pass/fail rate is identical before and after this
> patch. This is not to say it is a perfect patch- I have yet to pull valgrind
> out. However, this should be quite safe to use in all situations from here
> on out, and we can start plugging the memleaks.
>
> Original-work-by: Aaron Griffin <aaronmgriffin at gmail.com>
> Signed-off-by: Dan McGee <dan at archlinux.org>
> ---
> It works! All of the pactests currently passing still pass, and those that
> previously failed also still fail.
>
> Let me know if anything seems weird in this patch.

Wow. What was the kicker here? I know I had like 80% of pactests
failing, presumably to segfaults, last I looked. You said you got it
to like 66%, and now a day later it's back to normal. There had to be
one big impedance here.