[pacman-dev] [PATCH] New --asexplicit option

[Xavier]

Nagy Gabor wrote:
> diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt
> index 0da83a6..5a64f1a 100644
> --- a/doc/pacman.8.txt
> +++ b/doc/pacman.8.txt
> @@ -86,11 +86,16 @@ You can also use `pacman -Su` to upgrade all packages that are out of date. See
>   Options
>   -------
>   *\--asdeps*::
> -	Install packages non-explicitly; in other works, fake their install reason
> +	Install packages non-explicitly; in other words, fake their install reason
>   	to be installed as a dependency. This is useful for makepkg and other
>   	build from source tools that need to install dependencies before building
>   	the package.
>
> +*\--asexplicit*::
> +	Install packages explicitly; in other words, force their install reason to
> +	explicit. This is useful if you want mark a dependency as explictly
> +	installed.
> +
>   *-b, \--dbpath*<'path'>::
>   	Specify an alternative database location (a typical default is
>   	``/var/lib/pacman'').  This should not be used unless you know what you are


It would be nice if native english speakers could review the formulation 
of these two options.

For example what is better between :
	in other words, fake their install reason to be installed as a
	dependency.
and
	in other words, force their install reason to explicit

Both sound a bit strange to me.

Also, I believe it should be : 'if you want *to* mark a dependency...'

> diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c
> index 72b8934..5f0fbde 100644
> --- a/lib/libalpm/add.c
> +++ b/lib/libalpm/add.c

> @@ -671,12 +667,8 @@ static int commit_single_pkg(pmpkg_t *newpkg, int pkg_current, int pkg_count,
>
>   		/* we'll need to save some record for backup checks later */
>   		oldpkg = _alpm_pkg_dup(local);
> -		/* copy over the install reason (unless alldeps is set) */
> -	if(trans->flags&  PM_TRANS_FLAG_ALLDEPS) {
> -		newpkg->reason = PM_PKG_REASON_DEPEND;
> -	} else {
> +		/* copy over the install reason */
>   		newpkg->reason = alpm_pkg_get_reason(local);
> -	}
>
>   		/* pre_upgrade scriptlet */
>   		if(alpm_pkg_has_scriptlet(newpkg)&&  !(trans->flags&  PM_TRANS_FLAG_NOSCRIPTLET)) {

Just leaving that comment alone here looks strange : /* copy over the 
install reason */
Why not simply remove it?

The rest looks fine to me, thanks for the patch.