[pacman-dev] [PATCH] Make strip paths configurable

[Dan McGee]

On Tue, Jul 1, 2008 at 2:27 PM, Thomas Bächler <thomas at archlinux.org> wrote:
> Dan McGee schrieb:
>>>
>>> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
>>> index c809498..4a6f9b2 100644
>>> --- a/scripts/makepkg.sh.in
>>> +++ b/scripts/makepkg.sh.in
>>> @@ -737,9 +737,11 @@ tidy_install() {
>>>
>>>       if [ "$(check_option strip)" = "y" ]; then
>>>               msg2 "$(gettext "Stripping debugging symbols from binaries
>>> and libraries...")"
>>> -               local binary bindirs
>>> -               bindirs="bin lib sbin usr/bin usr/lib usr/sbin
>>> usr/local/bin usr/local/lib usr/local/sbin opt/*/bin opt/*/lib opt/*/sbin"
>>> -               find ${bindirs} -type f 2>/dev/null | while read binary ;
>>> do
>>> +               local binary
>>> +               if [ -z "${STRIP_DIRS[@]}" ]; then
>>> +                       STRIP_DIRS=(bin lib sbin
>>> usr/{bin,lib,sbin,local/{bin,lib,sbin}} opt/*/{bin,lib,sbin})
>>> +               fi
>>> +               find ${STRIP_DIRS[@]} -type f 2>/dev/null | while read
>>> binary ; do
>>
>> This breaks what was fixed here; you'll need to resubmit with that in
>> mind:
>>
>> http://projects.archlinux.org/?p=pacman.git;a=commitdiff;h=27943a04d6dd135628c2313525ebffbcd76cc514

The bash {} expansion was causing some problems I believe, otherwise
I'm not completely sure why I would have changed that. The referenced
patch definitely made that change, I wish I would have documented
better why...

-Dan