[pacman-dev] [PATCH] Resolvedeps rework

Nagy Gabor ngaba at bibl.u-szeged.hu
Sat Jul 5 15:26:45 EDT 2008


> Nagy Gabor wrote:
> >> +pmpkg_t *alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs,
> >> alpm_list_t *excluding, pmpkg_t *tpkg); 
> > 
> > Hm. This should be _alpm_resolvedep. Shall I resubmit the whole
> > patch? ;-)
> > 
> 
> I already pulled these patches on my git repo, without any editing,
> just to make it slightly easier for Dan to fetch them.
> So I can fix this minor problem, but just a question before I do : 
> couldn't this function be static, since it is only used inside deps.c 
> (which is why this error could be easily missed) ?
> 

I'd appreciate if you fixed this. This shouldn't be static, since
sync_addtarget rework uses this function (I catched this bug there).

Bye




More information about the pacman-dev mailing list