[pacman-dev] [PATCH] Add some verbosity to "-S provision" and "-S group"

[Dan McGee]

On Sat, Jul 5, 2008 at 8:03 AM, Nagy Gabor <ngaba at bibl.u-szeged.hu> wrote:
> >From f96b366e8b0e2fb3a74e3647e5e07ecd5b78430e Mon Sep 17 00:00:00 2001
> From: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> Date: Sat, 5 Jul 2008 14:55:18 +0200
> Subject: [PATCH] Add some verbosity to "-S provision" and "-S group"
>
> sync_addtarget rework removed the "warning: foo provides bar" message.
> This was reimplemented (which means, that resolvedeps will also print this message),
> and "fallback to group" message was also added.
>
> Signed-off-by: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> ---
>  lib/libalpm/deps.c |    2 ++
>  src/pacman/sync.c  |    2 +-
>  2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/lib/libalpm/deps.c b/lib/libalpm/deps.c
> index b58deea..4b99f5f 100644
> --- a/lib/libalpm/deps.c
> +++ b/lib/libalpm/deps.c
> @@ -552,6 +552,8 @@ pmpkg_t *_alpm_resolvedep(pmdepend_t *dep, alpm_list_t *dbs, alpm_list_t *exclud
>                                                continue;
>                                        }
>                                }
> +                               _alpm_log(PM_LOG_WARNING, _("provider package was selected (%s provides %s)\n"),
> +                                                        pkg->name, dep->name);
>                                return(pkg);
>                        }
>                }
> diff --git a/src/pacman/sync.c b/src/pacman/sync.c
> index 6877d85..1e2af45 100644
> --- a/src/pacman/sync.c
> +++ b/src/pacman/sync.c
> @@ -583,7 +583,7 @@ static int sync_trans(alpm_list_t *targets)
>                                        goto cleanup;
>                                }
>                                /* target not found: check if it's a group */
> -
> +                               printf(_("%s package not found, searching for group...\n"), targ);
Please use pm_printf() with WARNING or INFO, depending on what you use
in that other patch. I think INFO would be fine.

>                                for(j = sync_dbs; j; j = alpm_list_next(j)) {
>                                        pmdb_t *db = alpm_list_getdata(j);
>                                        grp = alpm_db_readgrp(db, targ);
> --
> 1.5.6.1
>
>
> _______________________________________________
> pacman-dev mailing list
> pacman-dev at archlinux.org
> http://archlinux.org/mailman/listinfo/pacman-dev
>