[pacman-dev] [PATCH] ABS - Specify repo or package to download on command-line
Allan McRae
allan at archlinux.org
Fri Jul 11 08:36:09 EDT 2008
Dan McGee wrote:
> On Fri, Jul 11, 2008 at 7:23 AM, Allan McRae <allan at archlinux.org> wrote:
>
>> Dan McGee wrote:
>>
>>> On Fri, Jul 11, 2008 at 6:54 AM, Allan McRae <allan at archlinux.org> wrote:
>>>
>>>
>>>> Hi all,
>>>>
>>>> I figured I could still send patches for ABS here for people to look at
>>>> since this is the address listed in --help output...
>>>>
>>>> Anyway, I mainly wanted a comment on this line:
>>>>
>>>> INCLUDE=$(echo $INCLUDE | tr " " "\n" | sort -u | tr "\n" " ")
>>>>
>>>> which takes $INCLUDE, sorts it and removes duplicate values. Is there a
>>>> better way to do this? Everything appears to still work if I don't do
>>>> this but it makes the rsync command much cleaner.
>>>>
>>>>
>>> In 5 minutes of hacking I can't come up with something better. Is this
>>> a concern however?
>>>
>>> $ echo "-i=core -i=community -i=core/foobar -i=core" | tr " " "\n" |
>>> sort -u | tr "\n" " "
>>> -i=community -i=core -i=core/foobar
>>>
>>>
>>>
>> I don't think so... But then, I am not sure what you are getting at there!
>>
>> That would occur if someone went "abs core extra core/foobar" but that
>> would be stupid given if you are syncing core then you will get
>> core/foobar. I don't think I will work around stupidity until later... :D
>>
>
> Hmm, then I missed the point of removing dupes I guess? When would we
> ever have a dupe?
Running "abs core/base core/pacman" would give something like "-i=core
-i=core/base -i=core -i=core/pacman". I think the extra "-i core" does
not really matter but there may be an edge case I am missing so that why
I wanted to remove the dupes.
Allan
More information about the pacman-dev
mailing list