[pacman-dev] [PATCH] Readd some symlink checking in file conflict code

Nagy Gabor ngaba at bibl.u-szeged.hu
Wed Jul 23 08:22:38 EDT 2008

> if(!_alpm_lstat(str, &pkgbuf) && lsbuf.st_ino == pkgbuf.st_ino)...
> /* lsbuf represents the conflicting file, pkgbuf loops over the
> 'files' of local package */
> Since there is no symlink here, _alpm_lstat is equivalent with stat
> (the code _assumed_ symlink here). 
Not the _alpm_lstat in this line is interesting here, but the alpm_lstat
which filled lsbuf earlier.

> So if you want to restore the old behaviour, this code-part can be
> replaced with an easy "find directory-name in localpkg's filelist"
> search (maybe tuned with realpath).

> I am considering a "cheaper" solution now, only check the old version
> of package (not the whole target list). But that cannot
s/But that cannot//

More information about the pacman-dev mailing list