[pacman-dev] [PATCH] Don't display filename on -Qip operation.

[Dan McGee]

On Mon, Jun 2, 2008 at 4:56 AM, Xavier <shiningxc at gmail.com> wrote:
> >From cafa4977a0639ebb30ed20974ad86bf404ca5044 Mon Sep 17 00:00:00 2001
> From: Xavier Chantry <shiningxc at gmail.com>
> Date: Wed, 28 May 2008 23:25:40 +0200
> Subject: [PATCH] Don't display filename on -Qip operation.
>
> Some previous commits apparently broke the get_filename function for
> package loaded with pkg_load (on a -Qip operation), so this field is always
> empty now.
> It would be easy to fill the pkg->filename field in pkg_load, but what is
> the point?
Because it would be correct for libalpm to fill this field- remember
there could be other frontends. So I think we need to take the correct
approach rather than the easy approach. :)

> The -Qip operation needs to be run like this : -Qip <filename>, so the
> filename is already known. There is no need to display it again.
> Besides, on a normal -Qi operation, the filename is not displayed either
> because this information is not stored in the local database.
>
> Signed-off-by: Xavier Chantry <shiningxc at gmail.com>
> ---
>  src/pacman/package.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/src/pacman/package.c b/src/pacman/package.c
> index 21213c4..1698806 100644
> --- a/src/pacman/package.c
> +++ b/src/pacman/package.c
> @@ -90,9 +90,6 @@ void dump_pkg_full(pmpkg_t *pkg, int level)
>        }
>
>        /* actual output */
> -       if(level == 0) {
> -               string_display(_("Filename       :"), alpm_pkg_get_filename(pkg));
> -       }
>        string_display(_("Name           :"), alpm_pkg_get_name(pkg));
>        string_display(_("Version        :"), alpm_pkg_get_version(pkg));
>        string_display(_("URL            :"), alpm_pkg_get_url(pkg));
> --
> 1.5.5.1
>
> _______________________________________________
> pacman-dev mailing list
> pacman-dev at archlinux.org
> http://archlinux.org/mailman/listinfo/pacman-dev
>