[pacman-dev] [PATCH] Don't display filename on -Qip operation.

[Dan McGee]

On Mon, Jun 2, 2008 at 7:23 AM, Xavier <shiningxc at gmail.com> wrote:
> On Mon, Jun 2, 2008 at 2:10 PM, Dan McGee <dpmcgee at gmail.com> wrote:
>> On Mon, Jun 2, 2008 at 4:56 AM, Xavier <shiningxc at gmail.com> wrote:
>>> >From cafa4977a0639ebb30ed20974ad86bf404ca5044 Mon Sep 17 00:00:00 2001
>>> From: Xavier Chantry <shiningxc at gmail.com>
>>> Date: Wed, 28 May 2008 23:25:40 +0200
>>> Subject: [PATCH] Don't display filename on -Qip operation.
>>>
>>> Some previous commits apparently broke the get_filename function for
>>> package loaded with pkg_load (on a -Qip operation), so this field is always
>>> empty now.
>>> It would be easy to fill the pkg->filename field in pkg_load, but what is
>>> the point?
>> Because it would be correct for libalpm to fill this field- remember
>> there could be other frontends. So I think we need to take the correct
>> approach rather than the easy approach. :)
>>
>
> It is not clear to me which is the correct approach because of this :
>
> "Besides, on a normal -Qi operation, the filename is not displayed either
> because this information is not stored in the local database."

Sure. But pkg_load is not technically a local or sync database, but
some "on-the-fly" created database which happens to be a package file,
right? I believe when we populate a pkg struct by way of a package
file, we can easily populate the filename field too (which is a
different debate from showing it at all on a -Qi* operation, so I
apologize for the slight hijacking).

-Dan