[pacman-dev] [PATCH] makepkg.sh.in is prepared for building of splittet packages

Allan McRae mcrae_allan at hotmail.com
Sun Jun 15 05:42:49 EDT 2008


silvio at port1024.net wrote:
> <snip>
>  
> +		backup_o=$backup
> +		conflicts_o=$conflicts
> +		depends_o=$depends
> +		groups_o=$groups
> +		install_o=$install
> +		license_o=$license
> +		pkgdesc_o=$pkgdesc
> +		pkgname_o=$pkgname
> +		pkgver_o=$pkgver
> +		provides_o=$provides
> +		replaces_o=$replaces
> +		url_o=$url
> <snip>
> +			[ "$backup_o" != "" ]    && backup=$backup_o       || unset backup
> +			[ "$conflicts_o" != "" ] && conflicts=$conflicts_o || unset conflicts
> +			[ "$depends_o" != "" ]   && depends=$depends_o     || unset depends
> +			[ "$groups_o" != "" ]    && groups=$groups_o       || unset groups
> +			[ "$install_o" != "" ]   && install=$install_o     || unset install
> +			[ "$license_o" != "" ]   && license=$license_o     || unset license
> +			[ "$pkgdesc_o" != "" ]   && pkgdesc=$pkgdesc_o     || unset pkgdesc
> +			[ "$pkgname_o" != "" ]   && pkgname=$pkgname_o     || unset pkgname
> +			[ "$pkgver_o" != "" ]    && pkgver=$pkgver_o       || unset pkgver
> +			[ "$provides_o" != "" ]  && provides=$provides_o   || unset provides
> +			[ "$replaces_o" != "" ]  && replaces=$replaces_o   || unset replaces
> +			[ "$url_o" != "" ]       && url=$url_o             || unset url
> <snip>
>   

I think it would be cleaner to get these in a loop and in the same order 
as in PKGBUILD.proto.  

As I said in another email about splitting packages, I really don't like 
the whole deleting the pkgdir at the end of packaging each split 
package. However, in general I think this approach to splitting packages 
is OK. 

Allan






More information about the pacman-dev mailing list