[pacman-dev] [PATCH] Rework needs_transaction() and add new needs_root() function

[Xavier]

On Sat, Mar 08, 2008 at 05:52:01PM +0100, Nagy Gabor wrote:
> >From 1c0e5473d2eee695b21ab7be1ea787d990853854 Mon Sep 17 00:00:00 2001
> From: Nagy Gabor <ngaba at bibl.u-szeged.hu>
> Date: Sat, 8 Mar 2008 17:41:46 +0100
> Subject: [PATCH] Rework needs_transaction() and add new needs_root() function
> 
> * "no targets specified" message in case of non-root 'pacman -A/U/S/R'
>
>
> diff --git a/src/pacman/util.h b/src/pacman/util.h
> index f2facbf..4b4eada 100644
> --- a/src/pacman/util.h
> +++ b/src/pacman/util.h
> @@ -36,7 +36,8 @@
>  /* update speed for the fill_progress based functions */
>  #define UPDATE_SPEED_SEC 0.2f
>  
> -int needs_transaction();
> +int needs_root(alpm_list_t *targets);
> +int needs_transaction(alpm_list_t *targets);
>  int getcols();
>  int makepath(const char *path);
>  int rmrf(const char *path);
> -- 
> 1.5.3.8
> 

I don't like this targets arg. Do we really need that? Imo, the current
behavior is acceptable.