[pacman-dev] [PATCH] Use sigaction instead of signal.

Xavier shiningxc at gmail.com
Sun Mar 9 13:06:06 EDT 2008


On Sun, Mar 09, 2008 at 12:00:59PM -0500, Dan McGee wrote:
> On Sun, Mar 9, 2008 at 7:15 AM, Chantry Xavier <shiningxc at gmail.com> wrote:
> > >From signal man page :
> >  "The behavior of signal() varies across Unix versions, and has also varied
> >  historically across different versions of Linux. Avoid its use: use
> >  sigaction(2) instead. See Portability below."
> >
> >  The code was taken from there :
> >  http://www.gnu.org/software/libtool/manual/libc/Sigaction-Function-Example.html
> >
> >  Signed-off-by: Chantry Xavier <shiningxc at gmail.com>
> >  ---
> >   src/pacman/pacman.c |   25 ++++++++++++++++++++-----
> >   1 files changed, 20 insertions(+), 5 deletions(-)
> >
> >  diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c
> >  index f46b71c..9c56eae 100644
> >  --- a/src/pacman/pacman.c
> >  +++ b/src/pacman/pacman.c
> >  @@ -212,7 +212,7 @@ static void cleanup(int ret) {
> >   * in a consistant state.
> >   * @param signum the thrown signal
> >   */
> >  -static void handler(int signum)
> >  +static void termination_handler(int signum)
> Any real reason to rename the function?
> 

Not at all, I just made up the handler name by my previous commit.
Then I just copied the code from the link above, which was using
termination_handler :) I didn't know which one was better.




More information about the pacman-dev mailing list