[pacman-dev] [PATCH] Read .PKGINFO directly from package file

[Xavier]

Aaron Griffin wrote:
> On Thu, Mar 27, 2008 at 4:37 AM, Xavier <shiningxc at gmail.com> wrote:
>> Dan McGee wrote:
>>  > With the addition of the archive_fgets() function, we can now skip the temp
>>  > file usage in pkg_load/parse_descfile that was not needed. This has a nice
>>  > benefit of probably being both faster, reducing code, and getting rid of
>>  > "expensive" file operations.
>>  >
>>  > Signed-off-by: Dan McGee <dan at archlinux.org>
>>  > ---
>>  >  lib/libalpm/package.c |   61 +++++++++----------------------------------------
>>  >  1 files changed, 11 insertions(+), 50 deletions(-)
>>  >
>>
>>  That looks great, nice job.
> 
> Pfft, don't pat him on the back TOO much. A lot of those deletions
> were comments... cheater! 8)
> 

Ahah, well not that much, there were quite a few lines for all these 
pointless file operations. I find the code nicer without them, and it's 
also one TODO less in the code. :)