[pacman-dev] [PATCH] Tidy up missing changelog error message

Allan McRae mcrae_allan at hotmail.com
Sat May 10 13:46:38 EDT 2008

Dan McGee wrote:
> On Sat, May 10, 2008 at 11:31 AM, Allan McRae <mcrae_allan at hotmail.com> wrote:
>>        if((fp = alpm_pkg_changelog_open(pkg)) == NULL) {
>> -               /* TODO after string freeze use pm_fprintf */
>> -               fprintf(stderr, _("error: no changelog available for '%s'.\n"),
>> +               pm_fprintf(stderr, PM_LOG_ERROR, "no changelog available for '%s'.\n",
> Ooo, nice.
> Any chance you want to fold this into a bigger patch, hopefully
> slightly tested, finding more of these types of things? This one
> wasn't alone.

Before, I continue on with this, does the patched version of the string 
above get flagged for translation?  I ask because the only other use of 
the pm_fprintf function I found was in pacman/pacman.c.

pm_fprintf(stderr, PM_LOG_ERROR, "Internal pacman error: Segmentation 
        "Please submit a full bug report with --debug if appropriate.\n");

Now, I can't find those strings in the files in the po/ folder.  These 
lines are in pacman-3.1.4 so should have been translated.  Am I missing 
something obvious or should the strings be surrounded with "_( )"?

More information about the pacman-dev mailing list