[pacman-dev] [PATCH] Allow local and sync db to be treated separately

[Xavier]

On Sun, May 11, 2008 at 7:02 PM, Dan McGee <dan at archlinux.org> wrote:
>
>  @@ -83,8 +83,7 @@ int SYMEXPORT alpm_pkg_checkmd5sum(pmpkg_t *pkg)
>
>         ASSERT(pkg != NULL, RET_ERR(PM_ERR_WRONG_ARGS, -1));
>         /* We only inspect packages from sync repositories */
>  -       ASSERT(pkg->origin == PKG_FROM_CACHE, RET_ERR(PM_ERR_PKG_INVALID, -1));
>  -       ASSERT(pkg->origin_data.db != handle->db_local, RET_ERR(PM_ERR_PKG_INVALID, -1));
>  +       ASSERT(pkg->origin == PKG_FROM_LOCALDB, RET_ERR(PM_ERR_PKG_INVALID, -1));
>

Hm, it is sync repositories and pkg->origin_data.db != handle->db_local,
so it should be SYNCDB and not LOCALDB, right?
However, I don't see why this function could not work with packages
from localdb. As long as it doesn't come from the file itself, it
should be fine. So I guess != PKG_FROM_FILE is fine, and the comment
could be changed.