[pacman-dev] [PATCHES] Refreshed PKGBUILDs

[Geoffroy Carrier]

Excerpts from Aaron Griffin's message of Mon May 19 02:08:49 +0200 2008:
> Um, first off, you *should* use full paths. The rationale has nothing
> to do with PATHs, but more to do with PATH ordering and things like
> that.

Are you suggesting we replace every instance of make to use
/usr/bin/make?

In that case, I bet 99% of PKGBUILDs are just WRONG.
asust % grep -r make /var/abs|wc -l
10835
asust % grep -r /usr/bin/make /var/abs|wc -l
135

Of course, this is completely inaccurate. But I think I've proven my
point, even for ABS (let's forget about AUR).

> Secondly, quoting everything is just plain stupid. Quoting only needs
> to be used on variable expansion (or, obviously, hardcoded paths with
> spaces).
I totally agree. I would just exclude cases like $_cvsroot, as spaces are
pretty rare in this variable (and the PKGBUILD writer should notice a
strange case).

-- 
Geoffroy Carrier
http://gcarrier.koon.fr/