[pacman-dev] [PATCH] Use "--mime" instead of file's "-i" parameter, to increase portability

Dan McGee dpmcgee at gmail.com
Tue May 20 15:29:33 EDT 2008


On Tue, May 20, 2008 at 12:51 PM, Sebastian Nowicki <sebnow at gmail.com> wrote:
> The equivalent of the "-i" argument for file on Linux is "-I" on BSD.
> Both version allow the use of the long option "--mime".
>
> Signed-off-by: Sebastian Nowicki <sebnow at gmail.com>
> ---
This seems fine, but the Arch manpage we have for file is from the BSD
General Commands Manual and documents both -i and --mime. I do see
that it is a 2008 revision, so perhaps older BSDs do not have the -i
option. Seems OK otherwise- Xavier, feel free to queue this up if you
are OK with it.

>  scripts/makepkg.sh.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 9da3687..ce5ac3f 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -606,7 +606,7 @@ extract_sources() {
>                fi
>
>                # fix flyspray #6246
> -               local file_type=$(file -bizL "$file")
> +               local file_type=$(file -bzL --mime "$file")
>                local cmd=''
>                case "$file_type" in
>                        *application/x-tar*|*application/zip*|*application/x-zip*|*application/x-cpio*)
> --
> 1.5.4.5
>
>
> _______________________________________________
> pacman-dev mailing list
> pacman-dev at archlinux.org
> http://archlinux.org/mailman/listinfo/pacman-dev
>




More information about the pacman-dev mailing list