[pacman-dev] [PATCH] Added the function parse_options to replace getopt

Dan McGee dpmcgee at gmail.com
Tue Nov 18 21:17:08 EST 2008


On Tue, Nov 18, 2008 at 7:46 PM, Allan McRae <allan at archlinux.org> wrote:
> Yun Zheng Hu wrote:
>>
>> This will make makepkg work properly on systems like Mac OS X, where
>> the default installed getopt does not handle long options.
>>
>> see also:
>> http://www.archlinux.org/pipermail/pacman-dev/2008-May/011830.html
>>
>> Signed-off-by: Yun Zheng Hu <yunzheng.hu at gmail.com>
>
> I need to go through this more fully but this seems OK to me.   One comment:
>  you should probably change the GETOPT GO BANG! stuff to something like
> "PARSE_OPTIONS FAILED", or preferably handle the error return properly.

Allan- I think I'll trust your judgment on this one, since you have
been the makepkg guru. As long as we don't lose functionality, I'm
fine with patches like this. When you pull it into your pacman tree,
I'll pull it into mine (on maint).

-Dan



More information about the pacman-dev mailing list