[pacman-dev] [PATCH] Fix a possible bash-4.0 problem in makepkg

Marc - A. Dahlhaus mad at wol.de
Sun Apr 26 08:36:00 EDT 2009


i've spotted a problem in makepkg's cleanup part if the host is running 
As makepkg runs bash with option -e, on bash-4.0 it fails if strip 
reports an unsupported binary.
The following trivial patch fixes the problem.

Signed-off-by: "Marc - A. Dahlhaus" <mad at wol.de>

--- pacman-3.2.2.orig/scripts/makepkg.sh.in
+++ pacman-3.2.2/scripts/makepkg.sh.in
@@ -766,11 +766,11 @@ tidy_install() {
         find ${STRIP_DIRS[@]} -type f 2>/dev/null | while read binary ; do
             case "$(file -biz "$binary")" in
                 *application/x-sharedlib*)  # Libraries (.so)
-                    /usr/bin/strip --strip-debug "$binary";;
+                    /usr/bin/strip --strip-debug "$binary" || true;;
                 *application/x-archive*)    # Libraries (.a)
-                    /usr/bin/strip --strip-debug "$binary";;
+                    /usr/bin/strip --strip-debug "$binary" || true;;
                 *application/x-executable*) # Binaries
-                    /usr/bin/strip "$binary";;
+                    /usr/bin/strip "$binary" || true;;

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: makepkg-bash4.patch
URL: <http://www.archlinux.org/pipermail/pacman-dev/attachments/20090426/c7cf20d5/attachment.diff>

More information about the pacman-dev mailing list