[pacman-dev] [PATCH] allow "makepkg -R" to first unpack an already built package when $pkgdir is empty

[Allan McRae]

Firmicus wrote:
> Xavier a écrit :
>   
>> On Fri, Aug 21, 2009 at 2:22 PM, FC<firmicus04 at googlemail.com> wrote:
>>   
>>     
>>> Allan McRae wrote:
>>>
>>>     
>>>       
>>>> FC wrote:
>>>>       
>>>>         
>>>>> >From ae3dd41af891f059b0aa1cc888eed873684b5580 Mon Sep 17 00:00:00 2001
>>>>> From: Francois Charette <francois at archlinux.org> <francois at archlinux.org>
>>>>> Date: Tue, 18 Aug 2009 22:10:56 +0200
>>>>> Subject: [PATCH] makepkg -R: allow unpacking when pkgdir is empty
>>>>>
>>>>> Also fixed some typos  :)
>>>>>
>>>>>         
>>>>>           
>>>> When you "additional" part of your patch is as large as the patch
>>>> itself, just make two patches.  I have not reviewed the typo fixes.
>>>>       
>>>>         
>>> Fair enough. Should I resend as two separate patches?
>>>
>>>     
>>>       
>> Yes in any cases, re-send the typo fixes, because this will be
>> definitely applied.
>>
>>   
>>     
>
> Here it is.
>
>   
>> As for the second patch, as you said, it's not clear whether it's
>> worth implementing.
>> imo this is a special case that can be handled manually.
>>
>>   
>>     
>
> Let's forget it then ;)

Overall, I do not mind this idea, it just needs some more thought on how 
to do it when package() functions are present.  Perhaps if $srcdir is 
"empty" when using "makepkg -R" and the package file is present then it 
should extract that package into pkgdir....   Needs more thought...

I'll add that if you use the build() function for the compiling and a 
package() function for the packaging steps, makepkg -R just runs the 
package() step so is usually quite fast.  As a bonus, doing this 
restricts the use of fakeroot to just the packaging stage. This was a 
new feature in pacman-3.3 and I recommend people use it.

Allan