[pacman-dev] [PATCH] makepkg: check for references to build root in package
allan at archlinux.org
Wed Dec 2 20:25:07 EST 2009
Dan McGee wrote:
> On Wed, Dec 2, 2009 at 12:17 PM, Cedric Staniewski <cedric at gmx.ca> wrote:
>> On 10/28/2009 10:07 PM, Jeff wrote:
>>> On Mon, Oct 26, 2009 at 09:08:21AM +1000, Allan McRae wrote:
>>>> I have adjusted the patch to use Cedric's syntax now that it is working
>>>> for me.
>>> FWIW, you can also make the line a tad shorter by using grep's -q
>>> instead of &>/dev/null.
>> I noticed this patch (latest revision) has not made it into master yet...
> I'm not convinced on this one as it has to scan the entire pkg/
> directory, which for some things, could be gigantic (icc,
> go-openoffice, etc.). Am I being over-performance crazy? I guess the
> zip is going to do it too...
> To me this seems way outside the realm of makepkg and belongs in namcap.
The problem with this is that namcap does not know anything about
$srcdir (and how can it) so cannot check for references to it. This is
unlike the check for missing backup files that is already in
check_package() which should probably be in namcap...
I also tested this in large packages (e.g. openoffice) and on my system
(2GHz) it takes ~10sec which is a very small fraction of the build time.
As an aside, extracting and grepping through the entire core+extra+some
of community takes me ~10min. Per package this is a tiny amount of time
and includes extraction of tarball and not having files in the cache.
More information about the pacman-dev