[pacman-dev] [PATCH] makepkg: remove srclinks directory on error exit

[Allan McRae]

Cedric Staniewski wrote:
> When makepkg exits in create_srcpackage(), the (temporary) srclinks
> directory is left behind.
> 
> Signed-off-by: Cedric Staniewski <cedric at gmx.ca>
> ---
>  scripts/makepkg.sh.in |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index ceaa8a6..b618881 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -118,6 +118,7 @@ trap_exit() {
>  		echo
>  		error "$@"
>  	fi
> +	[[ -n $srclinks ]] && rm -rf "$srclinks"
>  	exit 1
>  }
>  

I am not sure about this as if the source package creation fails, I 
would like to be able to look in the directory to track down why.  Much 
like how "-c" does not clear the source directory on a build failure. 
So my initial reaction is a -1.

As an aside, did you actually encounter an error during source package 
creation or just note that could be left behind from the code?

Allan