[pacman-dev] [PATCH] Allow vendor based DLAGENT settings in makepkg.conf

[Xavier]

On Sun, Feb 8, 2009 at 7:27 PM, Dan McGee <dpmcgee at gmail.com> wrote:
> On Sun, Feb 8, 2009 at 9:55 AM, Yun Zheng Hu <yunzheng.hu at gmail.com> wrote:
>> This patch will allow the default DLAGENT settings to be overridden in
>> the configure script. This will allow better default DLAGENT settings
>> for specific platforms/vendors. For example: Mac OS X does not have
>> wget installed by default, but it does have curl by default.
>>
>> Currently the patch only overrides the default FTP and HTTP/HTTPS
>> agents when configuring for Mac OS X.
>
> I like the intent of this patch, but not the implementation. I'm
> actually leaning away from all this customization stuff we do at all
> in makepkg.conf with configure.ac, as I really don't think it belongs
> there. I believe it is the responsibility of the downstream maintainer
> to tweak some of the shipped defaults, which is what we already do
> with Arch for both pacman.conf and makepkg.conf.
>
> Anyone else have opinions on this? Am I way off-base?
>

In this case, we should maybe use the most portable tools in the
default makepkg.conf from the repository. But I have no clue if curl
is more appropriate than wget if we consider all platforms.
Otherwise we could provide the two alternatives, like in pacman.conf :
  19 #XferCommand = /usr/bin/wget --passive-ftp -c -O %o %u
  20 #XferCommand = /usr/bin/curl %u > %o
Except than in the DLAGENT case, we probably want to uncomment one by default.