[pacman-dev] [PATCH] Mac OS X [1] Full path of stat (SIZECMD) and [2] sed -i

Dan McGee dpmcgee at gmail.com
Sun Feb 15 18:55:29 EST 2009


On Sun, Feb 15, 2009 at 5:18 PM, Kevin Barry <barryk at gmail.com> wrote:
> Change configure.ac to use the full path of stat when on darwin/mac.
> This is needed for situations when a user installs the GNU/coreutils
> and places it in their path before /usr/bin, but the SIZECMD is
> already configured for Darwin's version of stat.
>
> Signed-off-by: Kevin Barry <barryk gmail com>

Looks fine, thanks.

> Patch Number Two
>
> This patch changes the way that sed inplace is run in makepkg when
> running in versionpkg mode. Previous, sed would run with no backup
> file, called in the GNU way. It seems there is no cross platform
> method of calling sed inplace with no backup (BSD/sed uses sed -i '',
> GNU/sed uses sed -i'' or simply sed -i).
>
> Instead, this patch creates a backup file (.pkgsave) and removes it
> after the succesful completion of the sed operation. This means the
> user should not see the backup file, unless something went run (full
> hard drive?) in which case they don't lose the PKGBUILD as they would
> have before.
>
> Signed-off-by: Kevin Barry <barryk gmail com>

Please resend both of these patches as separate emails- git tools are
meant to have one patch per email, whether using format-patch or am.

-Dan


More information about the pacman-dev mailing list