[pacman-dev] Fwd: [PATCH] repo-add: fix eval and quote issues

[Dan McGee]

On Mon, Feb 9, 2009 at 1:17 PM, Xavier <shiningxc at gmail.com> wrote:
> For testing, I added all the packages in my cache to a database with
> and without this patch, and the resulting databases are identical so
> we should be safe.
> However, we have twice as many forks as before now, so the time went
> from 1:36 to 3:14 (for adding 493 packages).
> I don't know if we should care or not, I guess we usually add a small
> numbers of packages. If we care, we should have a look at all the
> slowest operations in repo-add.

It is actually way worse than 2x the number of forks- we now fork once
per file *per line* in our .PKGINFO file, whereas before we only
forked once per file.

New patch incoming on the ML that should fork as many times as the old
version, reducing that bottleneck a lot.

-Dan