[pacman-dev] [PATCH 1/2] Enabled new interactive prompt and updated some tests.

Bryan Ischo bji-keyword-pacman.3644cb at www.ischo.com
Sun Feb 22 06:33:28 EST 2009


Sebastian Nowicki wrote:
>
> On 22/02/2009, at 7:25 PM, Bryan Ischo wrote:
>
>> @@ -371,7 +371,8 @@ typedef enum _pmtransconv_t {
>>     PM_TRANS_CONV_REPLACE_PKG = 0x02,
>>     PM_TRANS_CONV_CONFLICT_PKG = 0x04,
>>     PM_TRANS_CONV_CORRUPTED_PKG = 0x08,
>> -    PM_TRANS_CONV_LOCAL_NEWER = 0x10
>> +    PM_TRANS_CONV_LOCAL_NEWER = 0x10,
>> +    PM_TRANS_CONV_REMOVE_PKGS = 0x20,
>> } pmtransconv_t;
>
> Would be nice to document this.

Yes, it would be nice if all of them were documented.  But none of them are.

I'm not trying to solve every existing problem with the pacman source.  
I'm just trying to add a new feature without making the code any 'worse' 
than it was ...

And to be honest, I would be happy to add this documentation, but ... 
I've already constructed and re-constructed my git patches so many times 
to satisfy requests on this list, I'm afraid I have no more energy to do 
it all over again just to add some comments in a place where no comments 
existed previously.  Sorry :(

Thanks,
Bryan



More information about the pacman-dev mailing list