[pacman-dev] [PATCH 1/2] Enabled new interactive prompt and updated some tests.

[Bryan Ischo]

Xavier wrote:
> On Sun, Feb 22, 2009 at 12:45 PM, Allan McRae <allan at archlinux.org> wrote:
>   
>> Bryan Ischo wrote:
>>     
>>>>> @@ -371,7 +371,8 @@ typedef enum _pmtransconv_t {
>>>>>    PM_TRANS_CONV_REPLACE_PKG = 0x02,
>>>>>    PM_TRANS_CONV_CONFLICT_PKG = 0x04,
>>>>>    PM_TRANS_CONV_CORRUPTED_PKG = 0x08,
>>>>> -    PM_TRANS_CONV_LOCAL_NEWER = 0x10
>>>>> +    PM_TRANS_CONV_LOCAL_NEWER = 0x10,
>>>>> +    PM_TRANS_CONV_REMOVE_PKGS = 0x20,
>>>>> } pmtransconv_t;
>>>>>           
>> Is that new dangling comma at the end there a bad thing?
>>
>>     
>
> A quick lookup on google tells me this is valid in C99 but not in C89 standard.

It was unintentional.  If I recreate my patches I will fix it.  If not, 
whoever applies my patches, can you please just fix that yourself in 
your tree?  Or don't fix it - there isn't a compiler made in 10 years 
that would have problems with that comma ....

Bryan