[pacman-dev] [PATCH 4/5] Add create-xdelta script to create deltas.

[Allan McRae]

Xavier Chantry wrote:
> This should obsolete the delta support in makepkg. Having a separate script
> should be more flexible.
>
> Example usage:
> $ create-xdelta repo/tzdata-2009a-1-x86_64.pkg.tar.gz repo/tzdata-2009b-1-x86_64.pkg.tar.gz
> ==> Generating delta from version 2009a-1 to version 2009b-1
> ==> Generated delta : 'repo/tzdata-2009a-1_to_2009b-1-x86_64.delta'
>
> Signed-off-by: Xavier Chantry <shiningxc at gmail.com>
> ---
>   

Not sure about the name.  I would prefer it mentioned pkg somehow as at 
the moment the is nothing in the name that indicates this is for pacman 
packages.  Maybe pkgdelta?

>  <snip>
> +
> +# print usage instructions
> +usage() {
> +	printf "create-xdelta (pacman) %s\n\n" "$myver"
> +	printf "$(gettext "Usage: create-xdelta <package1> <package2 ...\n")"
>   

Missing ">" after package 2. Why the "..." there?  The script only uses 
two parameters.


Otherwise, this is full of awesomeness and win.

Allan