[pacman-dev] [PATCH] makepkg: tidy version package tests

Dan McGee dpmcgee at gmail.com
Thu Jan 1 23:42:18 EST 2009


On Thu, Jan 1, 2009 at 10:37 PM, Allan McRae <allan at archlinux.org> wrote:
> The use if "! -z" to check if a string is not null is not good practice
> so replace with the "-n" option. Also use the AND comparison within one
> test rather than on two separate tests.
>
> Signed-off-by: Allan McRae <allan at archlinux.org>

Looks good to me, maint- worthy?

I really need to jump on making this darnded release, don't I...

-Dan


More information about the pacman-dev mailing list