[pacman-dev] [PATCH 1/4] Internal code reorganization in preparation for changes to package resolution.

[Bryan Ischo]

Dan McGee wrote:
> On Fri, Jan 16, 2009 at 9:04 PM, Bryan Ischo
> <bji-keyword-pacman.3644cb at www.ischo.com> wrote:
>   
>> Dan McGee wrote:
>>     
>>>
>>> Please wrap your commit message at 76 characters so it doesn't make
>>> the git-log console output go crazy.
>>>
>>>       
>> Heh.   Sorry about that.  I am usually Mr. Anal 80 column man.  Since the
>> pacman source doesn't obey 80 column line limits I assumed that nobody did
>> for anything ... but I guess that commit messages need to be wrapped.
>>  Believe me, I'm OK with that - I'd like to re-wrap all of the source too
>> but ... I'll resist the urge :)
>>     
>
> I believe the pacman source does, but we cheat a little bit- note the
> modelines in each file that change our tabstops to 4 characters rather
> than 8.
>   

Hm, well the HACKING file that lays out coding conventions doesn't 
mention line length.  And I only really worked heavily in 
lib/libalpm/deps.c and lib/libalpm/sync.c, and those files have many 
lines that exceed 80 columns.  But certainly other files I looked at 
also had lines exceeding 80 columns.  It looks like maybe at one time 
the files were 80-column clean but that further changes have violated 
that rule.  I do have my tab stops set at 4 spaces so I think you should 
see the same thing.

Knowing that there is supposed to be an 80 column rule, I'll be sure to 
obey that in the future.

Thanks,
Bryan