[pacman-dev] [PATCH] Ensure build failure if a single build() command fails

Aaron Griffin aaronmgriffin at gmail.com
Fri Jun 12 17:55:35 EDT 2009


On Fri, Jun 12, 2009 at 4:49 PM, Jürgen Hötzel<juergen at hoetzel.info> wrote:
> Hi,
>
> I doubt this was by intention:
>
> errors in build() functions are only fatal, if "--log" is enabled.
>
> I just made a buggy pkg because some "install ..." commands
> where not handled by "|| return 1".
>
> Our PKGBUILDs are cluttert full of "|| return 1". Failing commands in
> build functions should always result in an build error.

Might be worthwhile to add a source comment indicating something about
this. I don't know the details, but it looks to be the difference
between $PIPESTATUS[0] and $?


More information about the pacman-dev mailing list