[pacman-dev] [PATCH] makepkg: Move .PKGINFO creation into a function.

Loui Chang louipc.ist at gmail.com
Mon Jun 22 02:04:44 EDT 2009


Signed-off-by: Loui Chang <louipc.ist at gmail.com>
---
 scripts/makepkg.sh.in |   36 ++++++++++++++++++++----------------
 1 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index b555a03..2140ff0 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -871,22 +871,7 @@ tidy_install() {
 	fi
 }
 
-create_package() {
-	if [ -z "$1" ]; then
-		nameofpkg="$pkgname"
-	else
-		nameofpkg="$1"
-	fi
-
-	if [ ! -d "$pkgdir" ]; then
-		error "$(gettext "Missing pkg/ directory.")"
-		plain "$(gettext "Aborting...")"
-		exit 1 # $E_MISSING_PKGDIR
-	fi
-
-	cd "$pkgdir"
-	msg "$(gettext "Creating package...")"
-
+write_pkginfo() {
 	local builddate=$(date -u "+%s")
 	if [ -n "$PACKAGER" ]; then
 		local packager="$PACKAGER"
@@ -958,6 +943,25 @@ create_package() {
 		warning "$(gettext "Please add a license line to your %s!")" "$BUILDSCRIPT"
 		plain "$(gettext "Example for GPL\'ed software: license=('GPL').")"
 	fi
+}
+
+create_package() {
+	if [ ! -d "$pkgdir" ]; then
+		error "$(gettext "Missing pkg/ directory.")"
+		plain "$(gettext "Aborting...")"
+		exit 1 # $E_MISSING_PKGDIR
+	fi
+
+	if [ -z "$1" ]; then
+		nameofpkg="$pkgname"
+	else
+		nameofpkg="$1"
+	fi
+
+	write_pkginfo $nameofpkg
+
+	cd "$pkgdir"
+	msg "$(gettext "Creating package...")"
 
 	local comp_files=".PKGINFO"
 
-- 
1.6.3.2



More information about the pacman-dev mailing list