[pacman-dev] [PATCH] Revert "popen does NOT require /bin/sh in a subchroot"

Xavier shiningxc at gmail.com
Sun Mar 15 10:59:56 EDT 2009

On Sun, Mar 15, 2009 at 3:52 PM, Dan McGee <dpmcgee at gmail.com> wrote:
> On Sun, Mar 15, 2009 at 9:10 AM, Xavier Chantry <shiningxc at gmail.com> wrote:
>> This reverts commit 9558639d8009483fbf422b138d020745986f82f1.
>> This change was wrong, popen does require /bin/sh in a subchroot.
> Since you've removed the opposing comment in the code, can we stick
> the correct comment in the code? We've gone back and forth on this one
> like 1800 times.

Well, that's also what I thought, we had the right comment before and
it didn't help.

I realized it's better anyway to totally skip that check, and to not
even worry what is required or what isn't.
We just delay this to popen, since the return status is already
checked. This is better, transparent and more accurate.

We don't care about which sh is needed, the code does not care either,
that way everyone is happy and we do not need any comments, wrong or
false :)

More information about the pacman-dev mailing list