[pacman-dev] [PATCH] Fix extra commas at end of enumerator list in alpm.h
Gerardo Exequiel Pozzi
vmlinuz386 at yahoo.com.ar
Mon May 11 21:47:37 EDT 2009
Dan McGee wrote:
> On Mon, May 11, 2009 at 4:10 PM, Gerardo Exequiel Pozzi
> <vmlinuz386 at yahoo.com.ar> wrote:
>
>> Signed-off-by: Gerardo Exequiel Pozzi <vmlinuz386 at yahoo.com.ar>
>>
>
> The thought of this one is good, but I'm not going to take it. There
> are two main reasons:
> 1. The C spec/compilers allow this, so it works as is.
> 2. The trailing commas have a decent purpose when it comes to patches
> changing an enum- it prevents false positive line changes that consist
> only of adding a trailing comma to a previous line.
>
>
Ok thanks for the clarification.
1) Now i read about it in the spec ;)
2) True, I thought of that, but I gave importance to what I thought it
was std. I gotta get used to C9X, I am familiar with the C89 :)
--
Gerardo Exequiel Pozzi ( djgera )
http://www.djgera.com.ar
KeyID: 0x1B8C330D
Key fingerprint = 0CAA D5D4 CD85 4434 A219 76ED 39AB 221B 1B8C 330D
More information about the pacman-dev
mailing list