[pacman-dev] [PATCH] Add valgrind usage for testing purpose into the HACKING guide

[Allan McRae]

Laszlo Papp wrote:
> Signed-off-by: Laszlo Papp <djszapi at archlinux.us>
> ---
>  HACKING |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/HACKING b/HACKING
> index 09e782d..954d4b7 100644
> --- a/HACKING
> +++ b/HACKING
> @@ -133,6 +133,16 @@ For pacman:
>  #include "anythingelse.h"
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
> +How to test pacman more using valgrind?
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +Try to run some commands using valgrind with a command like:
> +
> +valgrind --leak-check=full --trace-children=yes -- src/pacman/.libs/pacman -Syu
> +
> +Be careful, valgrind reports lots of errors, even some errors that may not be related to
> +pacman. You should have a little experience of valgrind to ignore the noise.
> +
>  /////
>  vim: set ts=2 sw=2 syntax=asciidoc et:
>  /////

Why would we provide instructions on how to use valgrind?  That seems to 
  be a job for the valgrind authors...

Anyway, I believe the pactest suite is set up to use valgrind so you 
would be better using that to detect leaks.  Also,  we have a 
valgrind.supp file to suppress a lot of the false positives.

Allan